SIG_ALL: extent aggregated message to secret + C for inputs and amount + B_ for outputs #302

2025-10-24T08:58:50Z

callebtc commented

2025-10-24 08:58:50 +00:00

(Migrated from github.com)

The aggregation message now contains secret + C for each input and the keyset id + amount + B_ of each output in the transaction.

todo:

fix test vectors
nutshell: https://github.com/cashubtc/nutshell/pull/811
cdk: https://github.com/cashubtc/cdk/pull/1212
nutmix:
cashu-ts: https://github.com/cashubtc/cashu-ts/issues/386

The aggregation message now contains `secret` + `C` for each input and the keyset `id` + `amount` + `B_` of each output in the transaction. todo: - [x] fix test vectors - [ ] nutshell: https://github.com/cashubtc/nutshell/pull/811 - [x] cdk: https://github.com/cashubtc/cdk/pull/1212 - [ ] nutmix: - [ ] cashu-ts: https://github.com/cashubtc/cashu-ts/issues/386

SatsAndSports (Migrated from github.com) reviewed

2025-10-24 08:58:50 +00:00

SatsAndSports (Migrated from github.com) reviewed

2025-11-03 12:00:04 +00:00

11.md

					
				@ -126,15 +126,15 @@ The message to be signed depends on the type of transaction containing an input

The id here is now unnecessary:

Here, `||` denotes string concatenation. The `C` of each input and `id` and `B_` of
                                                                   ^^^^

The `id` here is now unnecessary: ``` Here, `||` denotes string concatenation. The `C` of each input and `id` and `B_` of ^^^^ ```

a1denvalu3 (Migrated from github.com) approved these changes

2025-11-04 07:35:42 +00:00

11.md

					
				@ -126,15 +126,15 @@ The message to be signed depends on the type of transaction containing an input

Here, `||` denotes string concatenation. The `C` of each input and `B_` of each output are **hex strings** and `amount` is a UTF-encoded string.

```suggestion Here, `||` denotes string concatenation. The `C` of each input and `B_` of each output are **hex strings** and `amount` is a UTF-encoded string. ```

robwoodgate (Migrated from github.com) reviewed

2025-11-14 17:34:45 +00:00

robwoodgate (Migrated from github.com) left a comment

I have tested the SIG_ALL test vectors for SwapRequest and MeltRequest and they seem ok.

.pre-commit-config.yaml

This file probably shouldn't be in here?

tests/11-test.md

					
				@ -102,33 +102,29 @@ Example `SwapRequest`:

				The following is the `msg_to_sign` on the above `SwapRequest`.

Some weirdness in the formatting here.

thesimplekid (Migrated from github.com) reviewed

2025-11-14 20:26:35 +00:00

.pre-commit-config.yaml

Yeah sorry. Added a gitignore pr so I stop doing this https://github.com/cashubtc/nuts/pull/309

thesimplekid (Migrated from github.com) reviewed

2025-11-14 20:28:10 +00:00

tests/11-test.md

					
				@ -102,33 +102,29 @@ Example `SwapRequest`:

				The following is the `msg_to_sign` on the above `SwapRequest`.

fixed in https://github.com/cashubtc/nuts/pull/302/commits/e4a08a7f3c417ad88b49afd6b10197bdeffff585

robwoodgate (Migrated from github.com) approved these changes

2025-11-14 23:28:32 +00:00

thesimplekid (Migrated from github.com) approved these changes

2025-11-15 12:44:32 +00:00

Sign in to join this conversation.

No reviewers

SatsAndSports

a1denvalu3

robwoodgate

thesimplekid

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

forgejo-admin/nuts!302

				`@ -126,15 +126,15 @@ The message to be signed depends on the type of transaction containing an input`

				@ -102,33 +102,29 @@ Example `SwapRequest`:
				The following is the `msg_to_sign` on the above `SwapRequest`.

Rows
Columns

SIG_ALL: extent aggregated message to secret + C for inputs and amount + B_ for outputs #302

SIG_ALL: extent aggregated message to `secret` + `C` for inputs and `amount` + `B_` for outputs #302