Update NUT-29 signature message to include mint pubkey and timestamp #363
No reviewers
Labels
No labels
breaking change
bug
documentation
enhancement
needs discussion
needs implementation
new nut
ready
wallet-only
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
forgejo-admin/nuts!363
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "update-sig-nut-29"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
This PR includes updates to the signature scheme and test vectors, intended to be merged into the branch for #341.
That's better approach to fix reply attack on https://github.com/cashubtc/nuts/pull/341
Concept ACK
2fd727aef4@ -24,2 +24,3 @@"pubkey_signatures": <Array[str]>"pubkey_signatures": <Array[str]>,"timestamp": <int>}We should add a hard rule about acceptable timestamp age - eg, mint will reject any timestamp older than xx minutes, and any timestamp greater than current epoch
@ -21,14 +21,18 @@ The wallet includes the following `PostMintQuotesByPubkeyRequest` data:```jsonI think 60 seconds may be too strict. We've had reports of mints having the time in the mint info off by 15 minutes.
@ -21,14 +21,18 @@ The wallet includes the following `PostMintQuotesByPubkeyRequest` data:```jsonWith NTP there should be little reason for clocks to be that far out really. I think maybe up to 300 seconds is more reasonable - still a 10 minute window overall.
NUT-29 signature message is already being changed in https://github.com/cashubtc/nuts/pull/375
Pull request closed