thesimplekid/fiach
1
0
Fork 0
Code Issues 5 Pull requests 2 Projects Releases Packages Wiki Activity Actions

Pin published PR reviews to the reviewed checkout commit #2

New issue
Open
opened 2026-10-21 18:20:29 +00:00 by thesimplekid · 0 comments
thesimplekid commented 2026-10-21 18:20:29 +00:00
Owner
Copy link

src/disclose.rs omits commit_id from ReviewPayload even though the reviewed checkout SHA is available. A push during review can attach findings to a newer commit or cause invalid anchors.

Pass the actual reviewed commit through to the GitHub review payload, including recovery paths. Do not substitute the current remote head.

Validation: assert the serialized publication payload uses the reviewed SHA when the remote head differs.

src/disclose.rs omits commit_id from ReviewPayload even though the reviewed checkout SHA is available. A push during review can attach findings to a newer commit or cause invalid anchors. Pass the actual reviewed commit through to the GitHub review payload, including recovery paths. Do not substitute the current remote head. Validation: assert the serialized publication payload uses the reviewed SHA when the remote head differs.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix_ci
fix/workspace-isolation
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
thesimplekid/fiach#2
No description provided.