Secret and well-known secret lengths #255

Open

a1denvalu3 wants to merge 1 commit from a1denvalu3/secret-length-refactor into main

a1denvalu3 commented

2025-05-02 08:58:28 +00:00

(Migrated from github.com)

This PR specifies that a secret should be a 64 hex string. A well-known secret may exceed this constraint, but their limits are to be decided on a case-by-case basis.

thesimplekid commented

2025-05-16 15:01:52 +00:00

(Migrated from github.com)

Closes #44

This pull request has changes conflicting with the target branch.

10.md
11.md
14.md

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

Merge pull request 'Secret and well-known secret lengths' (#255) from a1denvalu3/secret-length-refactor into main

Merge commit body

Reviewed-on: https://git.cashu.dev/forgejo-admin/nuts/pulls/255

Merge pull request 'Secret and well-known secret lengths' (#255) from a1denvalu3/secret-length-refactor into main

Reviewed-on: https://git.cashu.dev/forgejo-admin/nuts/pulls/255

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin a1denvalu3/secret-length-refactor:a1denvalu3/secret-length-refactor

git switch a1denvalu3/secret-length-refactor

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff a1denvalu3/secret-length-refactor

git switch a1denvalu3/secret-length-refactor

git rebase main

git switch main

git merge --ff-only a1denvalu3/secret-length-refactor

git switch a1denvalu3/secret-length-refactor

git rebase main

git switch main

git merge --no-ff a1denvalu3/secret-length-refactor

git switch main

git merge --squash a1denvalu3/secret-length-refactor