forgejo-admin/nuts
0
0
Fork 0
Code Issues 35 Pull requests 32 Projects Releases Packages Wiki Activity Actions

Use abbreviations for NUT-10 locking condition fields #274

Merged
d4rp4t merged 6 commits from main into main 2025-08-19 22:10:01 +00:00
Conversation 8 Commits 6 Files changed 3 +169 -5
d4rp4t commented 2025-07-20 14:52:58 +00:00 (Migrated from github.com)
Copy link
  • CDK
  • Nutshell
  • cashu-ts
- [x] CDK - [ ] Nutshell - [x] cashu-ts
gudnuf (Migrated from github.com) approved these changes 2025-07-20 15:35:52 +00:00
thesimplekid (Migrated from github.com) requested changes 2025-07-21 09:35:52 +00:00
thesimplekid (Migrated from github.com) left a comment
Copy link

Can we add test vectors?

Can we add test vectors?
a1denvalu3 commented 2025-07-21 10:56:28 +00:00 (Migrated from github.com)
Copy link

@thesimplekid done

@thesimplekid [done](https://github.com/d4rp4t/nuts/pull/1)
🚀 2
a1denvalu3 commented 2025-07-23 10:45:10 +00:00 (Migrated from github.com)
Copy link

@d4rp4t There is a wrong test case that doesn't align with the spec (uses transport type "http" with "g" tags set to "POST"). The LLM probably picked it up from cashu-ts, as I gave them as the reference test vectors.

I think you can just remove it.

@d4rp4t There is a wrong test case that doesn't align with the spec (uses transport type "http" with "g" tags set to "POST"). The LLM probably picked it up from cashu-ts, as I gave them as the reference test vectors. I think you can just remove it.
thesimplekid (Migrated from github.com) approved these changes 2025-07-26 13:54:56 +00:00
thesimplekid (Migrated from github.com) requested changes 2025-07-26 13:56:07 +00:00
thesimplekid (Migrated from github.com) left a comment
Copy link

@d4rp4t There is a wrong test case that doesn't align with the spec (uses transport type "http" with "g" tags set to "POST"). The LLM probably picked it up from cashu-ts, as I gave them as the reference test vectors.

I think you can just remove it.

Can we make sure this is removed, then LGTM

> @d4rp4t There is a wrong test case that doesn't align with the spec (uses transport type "http" with "g" tags set to "POST"). The LLM probably picked it up from cashu-ts, as I gave them as the reference test vectors. > I think you can just remove it. Can we make sure this is removed, then LGTM
thesimplekid (Migrated from github.com) reviewed 2025-07-26 14:09:39 +00:00
tests/18-tests.md
@ -0,0 +1,159 @@
# NUT-18 Test Vectors
thesimplekid (Migrated from github.com) commented 2025-07-26 14:08:55 +00:00
Copy link
      "t": "post",
      "a": "https://api.example.com/pay"
```suggestion "t": "post", "a": "https://api.example.com/pay" ```
thesimplekid (Migrated from github.com) commented 2025-07-26 14:09:28 +00:00
Copy link

Encode this based on above change

Encode this based on above change
thesimplekid (Migrated from github.com) approved these changes 2025-07-28 13:40:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
gudnuf
thesimplekid
Labels
Clear labels   
breaking change
This issue/PR entails breaking changes

  
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
enhancement
New feature or request

  
needs discussion
Needs more discussion

  
needs implementation
Needs a reference implementation

  
new nut
A new protocol NUT

  
ready
Ready to merge

  
wallet-only
A change that affects only wallets

No labels
breaking change
bug
documentation
enhancement
needs discussion
needs implementation
new nut
ready
wallet-only
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo-admin/nuts!274
No description provided.