forgejo-admin/nuts
0
0
Fork 0
Code Issues 35 Pull requests 32 Projects Releases Packages Wiki Activity Actions

NUT-21 and NUT-22 matching rules #334

Merged
robwoodgate merged 4 commits from nut21-22-match into main 2026-02-10 14:54:40 +00:00
Conversation 4 Commits 4 Files changed 2 +37 -8
robwoodgate commented 2026-01-27 20:32:47 +00:00 (Migrated from github.com)
Copy link

Clarifies protected_endpoints matching rules for NUT-21 and NUT-22

Clarifies `protected_endpoints` matching rules for NUT-21 and NUT-22 - [x] CDK: https://github.com/cashubtc/cdk/pull/1586 - [x] Cashu-TS: https://github.com/cashubtc/cashu-ts/pull/483 - [x] Nutshell: https://github.com/cashubtc/nutshell/pull/885
thesimplekid (Migrated from github.com) reviewed 2026-01-30 12:17:38 +00:00
thesimplekid (Migrated from github.com) left a comment
Copy link

Looks good. Do you think some test cases would be helpful?

Looks good. Do you think some test cases would be helpful?
22.md
@ -210,11 +210,11 @@ The mint lists each protected endpoint that requires a blind authentication toke
"protected_endpoints": [
thesimplekid (Migrated from github.com) commented 2026-01-30 11:47:42 +00:00
Copy link
      "path": "/v1/mint/*"
```suggestion "path": "/v1/mint/*" ```
thesimplekid (Migrated from github.com) commented 2026-01-30 11:48:05 +00:00
Copy link
      "path": "/v1/mint/*"

Since we're no longer using regex we should remove the ^.

```suggestion "path": "/v1/mint/*" ``` Since we're no longer using regex we should remove the ^.
robwoodgate commented 2026-01-30 13:15:01 +00:00 (Migrated from github.com)
Copy link

Looks good. Do you think some test cases would be helpful?

Thanks for removing the prefix anchor - I overlooked that.

Am happy to add tests, but wasn't sure a prefix match needs much more explanation than the example given?

But am too close to it, so if you think it's open to interpretation, then I will.

EDIT: https://github.com/cashubtc/nuts/pull/334/commits/21a0bd362e610003c98516f045423d475ea1e8a0 adds a couple more examples

> Looks good. Do you think some test cases would be helpful? Thanks for removing the prefix anchor - I overlooked that. Am happy to add tests, but wasn't sure a prefix match needs much more explanation than the example given? But am too close to it, so if you think it's open to interpretation, then I will. EDIT: https://github.com/cashubtc/nuts/pull/334/commits/21a0bd362e610003c98516f045423d475ea1e8a0 adds a couple more examples
thesimplekid (Migrated from github.com) approved these changes 2026-01-30 15:06:35 +00:00
thesimplekid (Migrated from github.com) left a comment
Copy link

LGTM. CDK PR https://github.com/cashubtc/cdk/pull/1586

LGTM. CDK PR https://github.com/cashubtc/cdk/pull/1586
robwoodgate commented 2026-01-30 16:14:15 +00:00 (Migrated from github.com)
Copy link

Cashu-TS PR: https://github.com/cashubtc/nuts/pull/334

Cashu-TS PR: https://github.com/cashubtc/nuts/pull/334
Sign in to join this conversation.
Reviewers
No reviewers
thesimplekid
Labels
Clear labels   
breaking change
This issue/PR entails breaking changes

  
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
enhancement
New feature or request

  
needs discussion
Needs more discussion

  
needs implementation
Needs a reference implementation

  
new nut
A new protocol NUT

  
ready
Ready to merge

  
wallet-only
A change that affects only wallets

No labels
breaking change
bug
documentation
enhancement
needs discussion
needs implementation
new nut
ready
wallet-only
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo-admin/nuts!334
No description provided.