NUT-11: Add SigAllSigningPackage transport format for multi-party SIG_ALL signing #345
No reviewers
Labels
No labels
breaking change
bug
documentation
enhancement
needs discussion
needs implementation
new nut
ready
wallet-only
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
forgejo-admin/nuts!345
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "KvngMikey/sigall_package"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #319
Adds a
SigAllSigningPackagesection to NUT-11 defining the wallet-ledtransport format for coordinating multi-party
SIG_ALLsigning.Defines:
SigAllSigningPackageshape, using existing NUT types (BlindedMessage)sigallAprefixsigallAstring forimplementation verification, added to
tests/11-test.mdSigning logic, merge behaviour, and coordination flow are intentionally omitted as implementation detail.
Related: [SigAll Signing Package -> cashubtc/cashu-ts/pull/485]
I prefer this approach to #319 - great work. Have left a couple of suggestions to tighten things up, otherwise great!
@ -154,6 +154,44 @@ msg = secret_0 || C_0 || ... || secret_n || C_n || amount_0 || B_0 || ... || amoSame comment as above.
[SIG_ALL swap example] is a non-functioning reference.
I wonder if we need the rest of this below... it's already in the test file.
Perhaps we should just remove lines 187-222 and replace with:
@ -409,3 +409,67 @@ The following is a valid multi-sig `SIG_ALL` `MeltRequest`.]One of these is not correct, because they are the same and the derivations are different.
Please can you check and update.
Great work @KvngMikey.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.