Simplify NUT-17 subscription kinds #372

Open

callebtc wants to merge 1 commit from nut-17-simplify-subscription-kind into main

callebtc commented

2026-05-21 08:47:43 +00:00

(Migrated from github.com)

Summary

replace method-specific SubscriptionKind values with generic mint_quote and melt_quote
keep proof_state unchanged
update NUT-17 command examples to advertise quote subscriptions per method-unit pair

Rationale

The subscription kind is now independent of the payment method, which makes the websocket API extensible to custom payment methods without needing method-specific quote kinds in the enum.

## Summary - replace method-specific `SubscriptionKind` values with generic `mint_quote` and `melt_quote` - keep `proof_state` unchanged - update NUT-17 command examples to advertise quote subscriptions per method-unit pair ## Rationale The subscription kind is now independent of the payment method, which makes the websocket API extensible to custom payment methods without needing method-specific quote kinds in the enum.

Egge21M commented

2026-05-21 09:44:41 +00:00

(Migrated from github.com)

I like it. However we should make sure that mints are fine with signaling support only on that high level instead of on a method level

robwoodgate (Migrated from github.com) approved these changes

2026-05-21 23:50:52 +00:00

robwoodgate (Migrated from github.com) left a comment

ACK. LGTM

a1denvalu3 (Migrated from github.com) approved these changes

2026-06-08 06:38:38 +00:00

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin nut-17-simplify-subscription-kind:nut-17-simplify-subscription-kind

git switch nut-17-simplify-subscription-kind

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff nut-17-simplify-subscription-kind

git switch nut-17-simplify-subscription-kind

git rebase main

git switch main

git merge --ff-only nut-17-simplify-subscription-kind

git switch nut-17-simplify-subscription-kind

git rebase main

git switch main

git merge --no-ff nut-17-simplify-subscription-kind

git switch main

git merge --squash nut-17-simplify-subscription-kind