feat(nut04/05): add method_name to [Mint|Melt]MethodSetting #374

Open
robwoodgate wants to merge 3 commits from robwoodgate/mint-melt-method-name into main
robwoodgate commented 2026-05-22 12:04:56 +00:00 (Migrated from github.com)

This PR adds an optional method_name param to the NUT-04 MintMethodSetting, and NUT-05 MeltMethodSetting.

The motivation is to make it easy for wallets to support custom payment methods in their UI.

- [x] Cashu-TS - https://github.com/cashubtc/cashu-ts/pull/672 - [ ] CDK - TBC - [ ] Nutshell - TBC This PR adds an optional `method_name` param to the NUT-04 `MintMethodSetting`, and NUT-05 `MeltMethodSetting`. The motivation is to make it easy for wallets to support custom payment methods in their UI. ##
callebtc (Migrated from github.com) reviewed 2026-05-22 12:13:25 +00:00
@ -133,13 +133,14 @@ The settings for this NUT indicate the supported method-unit pairs for minting.
{
callebtc (Migrated from github.com) commented 2026-05-22 12:13:25 +00:00
`min_amount` and `max_amount` indicate the minimum and maximum amount for an operation of this method-unit pair. `options` are method-specific and can be defined in method-specific NUTs. `method_name` is a human-readable name for the payment method.
```suggestion `min_amount` and `max_amount` indicate the minimum and maximum amount for an operation of this method-unit pair. `options` are method-specific and can be defined in method-specific NUTs. `method_name` is a human-readable name for the payment method. ```
callebtc (Migrated from github.com) reviewed 2026-05-22 12:13:37 +00:00
@ -236,13 +236,14 @@ The mint's settings for this NUT indicate the supported method-unit pairs for me
{
callebtc (Migrated from github.com) commented 2026-05-22 12:13:37 +00:00
`min_amount` and `max_amount` indicate the minimum and maximum amount for an operation of this method-unit pair. `options` are method-specific and can be defined in method-specific NUTs. `method_name` is a human-readable name for the payment method.
```suggestion `min_amount` and `max_amount` indicate the minimum and maximum amount for an operation of this method-unit pair. `options` are method-specific and can be defined in method-specific NUTs. `method_name` is a human-readable name for the payment method. ```
callebtc (Migrated from github.com) approved these changes 2026-05-22 12:13:45 +00:00
Kelbie commented 2026-05-22 13:01:35 +00:00 (Migrated from github.com)

Does it make sense to add localization here or is that too much? If wallets have language configuration we could pick the relevant one for the user.

Does it make sense to add localization here or is that too much? If wallets have language configuration we could pick the relevant one for the user.
robwoodgate commented 2026-05-22 13:12:22 +00:00 (Migrated from github.com)

Does it make sense to add localization here or is that too much? If wallets have language configuration we could pick the relevant one for the user.

I think too much for an info setting - could run to hundreds of entries. Wallet should make a policy decision to translate / ignore / decide their own names.

> Does it make sense to add localization here or is that too much? If wallets have language configuration we could pick the relevant one for the user. I think too much for an info setting - could run to hundreds of entries. Wallet should make a policy decision to translate / ignore / decide their own names.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin robwoodgate/mint-melt-method-name:robwoodgate/mint-melt-method-name
git switch robwoodgate/mint-melt-method-name

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff robwoodgate/mint-melt-method-name
git switch robwoodgate/mint-melt-method-name
git rebase main
git switch main
git merge --ff-only robwoodgate/mint-melt-method-name
git switch robwoodgate/mint-melt-method-name
git rebase main
git switch main
git merge --no-ff robwoodgate/mint-melt-method-name
git switch main
git merge --squash robwoodgate/mint-melt-method-name
git switch main
git merge --ff-only robwoodgate/mint-melt-method-name
git switch main
git merge robwoodgate/mint-melt-method-name
git push origin main
Sign in to join this conversation.
No description provided.