feat(nut04/05): add method_name to [Mint|Melt]MethodSetting #374
No reviewers
Labels
No labels
breaking change
bug
documentation
enhancement
needs discussion
needs implementation
new nut
ready
wallet-only
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
forgejo-admin/nuts!374
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "robwoodgate/mint-melt-method-name"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR adds an optional
method_nameparam to the NUT-04MintMethodSetting, and NUT-05MeltMethodSetting.The motivation is to make it easy for wallets to support custom payment methods in their UI.
@ -133,13 +133,14 @@ The settings for this NUT indicate the supported method-unit pairs for minting.{@ -236,13 +236,14 @@ The mint's settings for this NUT indicate the supported method-unit pairs for me{Does it make sense to add localization here or is that too much? If wallets have language configuration we could pick the relevant one for the user.
I think too much for an info setting - could run to hundreds of entries. Wallet should make a policy decision to translate / ignore / decide their own names.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.