custom payment methods #382
No reviewers
Labels
No labels
breaking change
bug
documentation
enhancement
needs discussion
needs implementation
new nut
ready
wallet-only
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
forgejo-admin/nuts!382
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "asmogo/generic-payment-method"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
support custom payment methods not defined in a dedicated NUT.
I think this is a fantastic step forward for wallets to be able to better support unknown methods - I've added some suggested tweaks to the base structs to make life even better.
@ -104,0 +120,4 @@### Websocket NotificationsCustom methods **MAY** support websocket subscriptions via [NUT-17][17] with kind `"{method}_mint_quote"`.Related: https://github.com/cashubtc/nuts/pull/372
@ -206,0 +215,4 @@### Websocket NotificationsCustom methods **MAY** support websocket subscriptions via [NUT-17][17] with kind `"{method}_melt_quote"`.Related: https://github.com/cashubtc/nuts/pull/372
Sorry @asmogo - I questioned an earlier draft that included
methodin the quote structs (thinking mint and wallet know by virtue of the endpoint used to request it), but this related issue highlights that for WS, and especially with the suggestion on harmonizing the base structs for custom methods, the distinction is easy to blur/lose.So maybe we DO need to include
method: <str>,in the quote structs for both mint and melt.Related https://github.com/cashubtc/nuts/pull/377
which adds the
amount_oaid,amount_issued,updated_atparms to default quote structsView command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.