fix a typo for nut08 #60

Closed

biluohc wants to merge 1 commit from patch-1 into main

biluohc commented

2023-10-19 04:01:45 +00:00

(Migrated from github.com)

No description provided.

thunderbiscuit (Migrated from github.com) approved these changes

2023-10-21 18:29:46 +00:00

thunderbiscuit (Migrated from github.com) left a comment

ACK 998cb8de3a. I had noted the same thing a few weeks ago.

We should make sure this change is disseminated widely however, because it is a breaking change in the serialization of the PostMeltRequest object.

Note also that PR #55 renames the pr field to request in the CheckFeesRequest object. We should make sure we use consistent wording across objects in the spec, and this fix might be better done as part of #55. @callebtc it's your call on this.

ACK 998cb8de3a11b6bb3f739a6ac3c9127b6b02ac53. I had noted the same thing a few weeks ago. We should make sure this change is disseminated widely however, because it is a breaking change in the serialization of the `PostMeltRequest` object. Note also that PR #55 renames the `pr` field to `request` in the `CheckFeesRequest` object. We should make sure we use consistent wording across objects in the spec, and this fix might be better done as part of #55. @callebtc it's your call on this.

callebtc commented

2023-10-26 10:24:56 +00:00

(Migrated from github.com)

Thanks for the PR but we can't merge this. This isn't a typo but renaming a field and would break the protocol.

@thunderbiscuit is right that we want to rename this field to a more generic name request which can harbor lightning invoices, on-chain addresses, or whatever else we might encounter along the way.

Thanks for the PR but we can't merge this. This isn't a typo but renaming a field and would break the protocol. @thunderbiscuit is right that we want to rename this field to a more generic name `request` which can harbor lightning invoices, on-chain addresses, or whatever else we might encounter along the way.

biluohc commented

2023-10-26 14:35:55 +00:00

(Migrated from github.com)

https://github.com/cashubtc/nuts/blob/main/08.md#example-1

So what is Everything here is the same as in [NUT-05](https://github.com/cashubtc/nuts/blob/main/05.md) except for outputs. ?

https://github.com/cashubtc/nuts/blob/main/08.md#example-1 So what is `Everything here is the same as in [NUT-05](https://github.com/cashubtc/nuts/blob/main/05.md) except for outputs.` ?

thesimplekid commented

2023-10-26 19:33:39 +00:00

(Migrated from github.com)

So what is Everything here is the same as in NUT-05 except for outputs. ?

Yes, it allows for change to be returned if the routing fee is over paid.

> So what is Everything here is the same as in [NUT-05](https://github.com/cashubtc/nuts/blob/main/05.md) except for outputs. ? Yes, it allows for change to be returned if the routing fee is over paid.